Check out Makruk (Thai Chess), our featured variant for March, 2025.

Enter Your Reply

The Comment You're Replying To
🕸Fergus Duniho wrote on Sat, Jan 9, 2021 05:21 PM UTC in reply to H. G. Muller from Fri Jan 8 09:13 PM:

I have the feeling something changed in the implementation of the GAME-code askpromote command that broke it.

Not exactly broke. More that your expectations about how it works are not up-to-date.

Above the Pawn there is a message that says it declines promotion. I don't recall having seen that before.

This appears only where there is an option to not promote.

After you make the choice and submit it through the button, it seems the original move is gone. The askpromote screen is supposed to append the choice to the move you had so far, in the form "; X-dest" (where X is the label of the chosen piece). But here it seems to replace the move by that, so that this now becomes the only move primitive. Which is of course invalid.

I am not aware that it replaces anything. Looking at the code for askpromote, which you can view yourself here, I only see where it keeps the original move without appending anything additional to it. This is for when the piece does not promote. Adding something like P-dest to the end of the move is an ugly kludge that I figured out how to do without. If you take a look at the Pawn subroutines in the fairychess include file, you will find code that handles optional Pawn promotion without the need to append a fake promotion to the end of the move. I believe the critical code looks like this:

if onboard where #to 0 #pzs: // Not yet in promotion zone
  if != space #to $moved:
    set name alias const alias $moved;
    die "You may not promote a" #name "until it reaches the promotion zone.";
  endif;
elseif onboard where #to 0 1: // Not yet on last rank
  if == White_Pawn const alias space #to and count var wprom:
    if not $answered and == mln $maxmln:
      push wprom space #to;
      askpromote #wprom;
  endif;
elseif ...

The first if-block is executed if it is not yet in the promotion zone. So, each subsequent elseif-block can be executed only if it is in the promotion zone. The second elseif-block executes if it is not yet on the last rank. So, if it does execute, the Pawn is in the promotion zone but not yet on the last rank. It then checks whether there is anything to promote to. If there is, then it checks two more things. And these are the important things to pay attention to. It checks whether this is the last move by comparing mln with $maxmln, and it checks whether askpromote has already been used on this move by checking the $answered flag. As long as it is the last move, and askpromote has not already been used on this move, it adds the Pawn to the promotion options and calls askpromote. Because it checks these two things, it does not have to check whether the move already contains a promotion, and that allows a player to decline a promotion without adding a fake promotion (or a skip or pass) to the move.


Edit Form

Comment on the page Play-test applet for chess variants

Conduct Guidelines
This is a Chess variants website, not a general forum.
Please limit your comments to Chess variants or the operation of this site.
Keep this website a safe space for Chess variant hobbyists of all stripes.
Because we want people to feel comfortable here no matter what their political or religious beliefs might be, we ask you to avoid discussing politics, religion, or other controversial subjects here. No matter how passionately you feel about any of these subjects, just take it someplace else.
Avoid Inflammatory Comments
If you are feeling anger, keep it to yourself until you calm down. Avoid insulting, blaming, or attacking someone you are angry with. Focus criticisms on ideas rather than people, and understand that criticisms of your ideas are not personal attacks and do not justify an inflammatory response.
Quick Markdown Guide

By default, new comments may be entered as Markdown, simple markup syntax designed to be readable and not look like markup. Comments stored as Markdown will be converted to HTML by Parsedown before displaying them. This follows the Github Flavored Markdown Spec with support for Markdown Extra. For a good overview of Markdown in general, check out the Markdown Guide. Here is a quick comparison of some commonly used Markdown with the rendered result:

Top level header: <H1>

Block quote

Second paragraph in block quote

First Paragraph of response. Italics, bold, and bold italics.

Second Paragraph after blank line. Here is some HTML code mixed in with the Markdown, and here is the same <U>HTML code</U> enclosed by backticks.

Secondary Header: <H2>

  • Unordered list item
  • Second unordered list item
  • New unordered list
    • Nested list item

Third Level header <H3>

  1. An ordered list item.
  2. A second ordered list item with the same number.
  3. A third ordered list item.
Here is some preformatted text.
  This line begins with some indentation.
    This begins with even more indentation.
And this line has no indentation.

Alt text for a graphic image

A definition list
A list of terms, each with one or more definitions following it.
An HTML construct using the tags <DL>, <DT> and <DD>.
A term
Its definition after a colon.
A second definition.
A third definition.
Another term following a blank line
The definition of that term.