Check out Makruk (Thai Chess), our featured variant for March, 2025.

Enter Your Reply

The Comment You're Replying To
H. G. Muller wrote on Sat, Apr 26 03:32 AM EDT in reply to Fergus Duniho from Fri Apr 25 08:30 PM:

Sorry, I bungled this big time. I just slipped in a simple line of code in all 3 betza.js scripts before switching off the PC and going to bed. That will teach me to never, never make a change without testing. The almost infallible rule is that when I paste in a line of code in multiple places it ALWAYS contains a bug or typo.

In this case I had written "if(sats === undefined)", and it turns out this causes a run-time error when sats is undefined. It had to be "if(typeof(sats) == 'undefined')".

I fixed that now, and to test whether it worked as expected I scrolled down through the Comments list until I encountered a page with three Diagrams. The first of that was apparently the Comment you are using for experimenting with the background buttons. The second Diagram, which was my recent, modernized copy of the old Xiangqi Diagram, refused to be parsed unless I viewed it is isolation.

In figuring that out, and to explain the unexpected Diagram numbering the sats[] array showed of the other two Diagrams (the one appearing first had the highest number!), I discovered the following problems:

1) The two Xiangqi Diagrams used the same value for satellite=xiang. This thwarts the purpose of allowing external elements to recognize which Diagram they belong to by discriminating them by satellite.

2) Your Diagram was cloned from mine, which was again cloned from the very old Xiangqi Diagram. In that thime Diagrams were recognized by the betza.js script by having id="diagram". Both clones still had that. But in HTML the ids are supposed to be unique, and with getElementById() it would only find the first one. This is why my Diagram was ignored. For allowing multiple Diagrams on one page I later switched to recognizing Diagrams by class="idiagram"; with geteElementsByClassName() you can then get an array of all Diagrams on the page. For backward compatibility it still also looks for an id="diagram", and if it finds one it adds that to the array as last element. This explained why the first Diagram got the highest index in the array.

I now corrected both issues by having my Xiangqi diagram use satellite=xiang2, and making all Diagrams flagging their presence through class, rather than id. This should cause the page to behave less erattically. In the console log the script now prints

Object { piece: 2, xiang2: 1, xiang: 0 }

for the sats[] array after the last Diagram has been parsed. ('piece' is the default value for satellite, and represents HaruN Y's Diagram on that page).

BTW, I noticed you were using very many buttons for different styles. I don't know what your objections were to the layout of the auto-generated buttons, but it is possible to control that layout somewhat: If a set name starts with an asterisk, like set=*Oriental, the asterisk would be stripped off the name, and the button would be placed on a new line. That way you can prevent uncontrolled wrapping in a large row of buttons.

If you don't want to use auto-generated buttons, you can still divide up the Diagram definition in sets, by using numeric values for the set indicators; this suppresses creation of buttons. You can then make your own buttons select a set by having them call TwitchDiag(diagNr, setNr). The diagNr you could get in a reliable way as sats[satelliteValue]. But for the main Diagram on an article page, where no one can pre-empt you with other Diagrams, it would always be 0. (If you identify the Diagram by class, that is.)


Edit Form

Comment on the page Xiangqi: Chinese Chess

Conduct Guidelines
This is a Chess variants website, not a general forum.
Please limit your comments to Chess variants or the operation of this site.
Keep this website a safe space for Chess variant hobbyists of all stripes.
Because we want people to feel comfortable here no matter what their political or religious beliefs might be, we ask you to avoid discussing politics, religion, or other controversial subjects here. No matter how passionately you feel about any of these subjects, just take it someplace else.
Avoid Inflammatory Comments
If you are feeling anger, keep it to yourself until you calm down. Avoid insulting, blaming, or attacking someone you are angry with. Focus criticisms on ideas rather than people, and understand that criticisms of your ideas are not personal attacks and do not justify an inflammatory response.
Quick Markdown Guide

By default, new comments may be entered as Markdown, simple markup syntax designed to be readable and not look like markup. Comments stored as Markdown will be converted to HTML by Parsedown before displaying them. This follows the Github Flavored Markdown Spec with support for Markdown Extra. For a good overview of Markdown in general, check out the Markdown Guide. Here is a quick comparison of some commonly used Markdown with the rendered result:

Top level header: <H1>

Block quote

Second paragraph in block quote

First Paragraph of response. Italics, bold, and bold italics.

Second Paragraph after blank line. Here is some HTML code mixed in with the Markdown, and here is the same <U>HTML code</U> enclosed by backticks.

Secondary Header: <H2>

  • Unordered list item
  • Second unordered list item
  • New unordered list
    • Nested list item

Third Level header <H3>

  1. An ordered list item.
  2. A second ordered list item with the same number.
  3. A third ordered list item.
Here is some preformatted text.
  This line begins with some indentation.
    This begins with even more indentation.
And this line has no indentation.

Alt text for a graphic image

A definition list
A list of terms, each with one or more definitions following it.
An HTML construct using the tags <DL>, <DT> and <DD>.
A term
Its definition after a colon.
A second definition.
A third definition.
Another term following a blank line
The definition of that term.