Check out Makruk (Thai Chess), our featured variant for March, 2025.

Enter Your Reply

The Comment You're Replying To
H. G. Muller wrote on Fri, Apr 25 03:25 PM UTC in reply to Fergus Duniho from 01:41 PM:

This is why it is important to be able to use background= instead of getElementById('board0').style.backgroundImage= in the JavaScript for a button. Since I would prefer to use my own buttons for better control of the layout, I'm hoping you can update Display() to change the background image to whatever the value of background is.

I don't think using Display would bring any solace: it would also not know what Diagram your hand-made buttons belong to. It would do the replacement in the currently active Diagram on the page, which might not at all be the Diagram you intended it to work for. If you want to get the same results as when Display() would do the replacement, you can write

 

getElementById('board' + active).style.backgroundImage=... 
  

The variable 'active' keeps the number of the Diagram that last received a mouse click. (Or any other activity, such as opening the AI panel.) Each clickable element in a Diagram knows the number of the Diagram it belongs to, and passes that to the click handler. If this is not the Diagram indicated by 'active', the routine SwitchDiag() is called to re-initialize the clicked Diagram before handling the click, and this becomes the new active Diagram. Display() uses this 'active' variable to address the squares it has to change, and would also use it to decide which background to alter.

The problem is that the Diagram numbers are dynamically generated during Initialization, on loading the page. The initialization routine collects all HTML element with class="idiagram", through getElementsByClassName('idiagram'). This delivers an array with the HTML elements as objects in it, in the order the Diagrams appear on the page. And the index in that array will be the Diagram number. When it then realizes the Diagrams one by one it uses this number in the id attribute of all Diagram elements, and as argument in the calls to event handlers attached to these elements. But as new Diagrams appear on the page, the numbers will change. So it is not possible to refer to the Diagrams through a hardcoded number in a button.

In principle the satellite parameter was introduced to associate external elements with a given Diagram. But that only works for elements that the Diagram initializator actively searches on the page (such as piece lists).

The only solution I can think of is to somehow 'broadcast' the Diagram numbers in a global associative array, indexed by the satellite value. That could be used to write things like

 

getElementById('board' + sats['xiangqiMainDiagram']).style.backgroundImage=... 
  

to make sure that you will always opperate on the Diagram with satellite=xiangqiMainDiagram in its specifications.


Edit Form

Comment on the page Xiangqi: Chinese Chess

Conduct Guidelines
This is a Chess variants website, not a general forum.
Please limit your comments to Chess variants or the operation of this site.
Keep this website a safe space for Chess variant hobbyists of all stripes.
Because we want people to feel comfortable here no matter what their political or religious beliefs might be, we ask you to avoid discussing politics, religion, or other controversial subjects here. No matter how passionately you feel about any of these subjects, just take it someplace else.
Avoid Inflammatory Comments
If you are feeling anger, keep it to yourself until you calm down. Avoid insulting, blaming, or attacking someone you are angry with. Focus criticisms on ideas rather than people, and understand that criticisms of your ideas are not personal attacks and do not justify an inflammatory response.
Quick Markdown Guide

By default, new comments may be entered as Markdown, simple markup syntax designed to be readable and not look like markup. Comments stored as Markdown will be converted to HTML by Parsedown before displaying them. This follows the Github Flavored Markdown Spec with support for Markdown Extra. For a good overview of Markdown in general, check out the Markdown Guide. Here is a quick comparison of some commonly used Markdown with the rendered result:

Top level header: <H1>

Block quote

Second paragraph in block quote

First Paragraph of response. Italics, bold, and bold italics.

Second Paragraph after blank line. Here is some HTML code mixed in with the Markdown, and here is the same <U>HTML code</U> enclosed by backticks.

Secondary Header: <H2>

  • Unordered list item
  • Second unordered list item
  • New unordered list
    • Nested list item

Third Level header <H3>

  1. An ordered list item.
  2. A second ordered list item with the same number.
  3. A third ordered list item.
Here is some preformatted text.
  This line begins with some indentation.
    This begins with even more indentation.
And this line has no indentation.

Alt text for a graphic image

A definition list
A list of terms, each with one or more definitions following it.
An HTML construct using the tags <DL>, <DT> and <DD>.
A term
Its definition after a colon.
A second definition.
A third definition.
Another term following a blank line
The definition of that term.